test: replace common.fixturesDir w/ fixtures.path#15819
Closed
Druotic wants to merge 1 commit intonodejs:masterfrom
Closed
test: replace common.fixturesDir w/ fixtures.path#15819Druotic wants to merge 1 commit intonodejs:masterfrom
Druotic wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
benjamingr
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
lpinca
approved these changes
Oct 9, 2017
Member
Member
|
There is a small typo in commit message: |
Druotic
force-pushed
the
test-tls-connect-secure-context-common-fixtures
branch
from
62e38e3 to
3f62305
Compare
Druotic
changed the title
Contributor
Author
|
Fixed the typo. @lpinca |
BridgeAR
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 9, 2017
Member
|
Landed in 85a5a2c. |
lpinca
pushed a commit
that referenced
this pull request
Oct 10, 2017
PR-URL: #15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Thanks for the contribution! 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15819 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
test/parallel/test-tls-connect-secure-context.js, replacecommon.fixturesDirwith usage of thecommon.fixturesmodule.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Simple test change for Node Interactive code and learn session.